dorianpb / cem

Reimplementation of Custom Entity Models in Minecraft for the Fabric Modloader
GNU Lesser General Public License v3.0
125 stars 38 forks source link

[FEATURE REQUEST/BUG?] Mobs that can be caught in buckets re-roll their custom textures #144

Open KawaiiBakemono opened 1 year ago

KawaiiBakemono commented 1 year ago

Version

Describe the bug

Hi there! I'd like to suggest a fix to an oversight (that seems to be apparent in any CEM mod, including Optifine), that being entities caught in buckets will re-roll their custom texture when released. For this example I demonstrated Axolotls, but this also applies to the following bucketable mobs:

Here shown is all 5 Axolotl variants bearing a custom texture (these were by random chance, I re-rolled them to obtain the texture I wanted)

Now watch what happens when I bucket it and put it back:

The texture changed!

By capturing and placing the Axolotls over and over, I can achieve their vanilla textures without ever having to summon a new entity. When I discovered this I was a bit frustrated, because players might be confused when they caught a green Axolotl in a bucket and once they release it, it's pink. Although you can get that texture back, you have to brute force it.

I hope this makes sense, if you have any questions feel free to ask!

Expected behavior

Mobs should retain their custom texture regardless of their status as an item or entity.

Desktop (please complete the following information):