dorianpb / cem

Reimplementation of Custom Entity Models in Minecraft for the Fabric Modloader
GNU Lesser General Public License v3.0
125 stars 38 forks source link

Lang files question #45

Closed Julienraptor01 closed 2 years ago

Julienraptor01 commented 2 years ago

Why do you do this

  "config.cem.use_optifine_folder.tooltip.0": "This will load CEM models from  ",
  "config.cem.use_optifine_folder.tooltip.1": "assets/minecraft/optifine/cem,",
  "config.cem.use_optifine_folder.tooltip.2": "which is exactly what optifine does.",
  "config.cem.use_optifine_folder.tooltip.3": "Reload resources (F3 + T) for",
  "config.cem.use_optifine_folder.tooltip.4": "this to take effect!",

instead of just using \n to create a new line ?

  "config.cem.use_optifine_folder.tooltip": "This will load CEM models from\nassets/minecraft/optifine/cem\nwhich is exactly what optifine does.\nReload resources (F3 + T) for\nthis to take effect!",

(modified example)

Julienraptor01 commented 2 years ago

i'm asking this because i want to translate this mod.

dorianpb commented 2 years ago

Minecraft doesn't support '\n', it's the only way to have more than once line

Julienraptor01 commented 2 years ago

Why does it work there ? What is different ? https://github.com/PepperCode1/Item-Model-Fix/blob/1.18/dev/src/main/resources/assets/itemmodelfix/lang/en_us.json

dorianpb commented 2 years ago

wait what didn't know that was possible just do it either way you want then

Julienraptor01 commented 2 years ago

No problem. We can't always know everything. Do i modify other languages too ?

dorianpb commented 2 years ago

honestly I'm not sure the other way is better (the fabric wiki recommends my way) so let me handle that

Julienraptor01 commented 2 years ago

OK I'm going to wait until you know what is the best thing to do

dorianpb commented 2 years ago

if you want me to choose which way, do it my way, but honestly I don't really care much

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 14 days. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically closed due to it being stale for 28 days. Thank you to everyone who contributed.