dorianpb / cem

Reimplementation of Custom Entity Models in Minecraft for the Fabric Modloader
GNU Lesser General Public License v3.0
125 stars 38 forks source link

Collect good resource packs #9

Open Madis0 opened 3 years ago

Madis0 commented 3 years ago

Consider making a wiki (text file, gist, etc) where you'll collect a list of current resource packs that work well with this mod. I tried a few and did not succeed for the most part, regardless of whether the second compatibility option is enabled or not.

dorianpb commented 3 years ago

Is there any chance you could show me some of these errors? Also what config options are you using?

Madis0 commented 3 years ago

Also what config options are you using?

Both of your options enabled - Optifine compatibility and model creation fix.

Here's a quick test on Super Mario Craft:

With model creation fix 2021-08-31_18 28 51

Without model creation fix 2021-08-31_18 29 13

MC 1.17.1, CEM 0.6.2, Fabric API 0.39.2+1.17, CompleteConfig 1.1.0, ClothConfig 5.0.38, Mod Menu 2.0.5

dorianpb commented 3 years ago

I was looking at Super Mario Craft, and from what I can tell from a few minutes, the model errors are caused by animation problems only. Apart from absolute animations, it looks like all the models are loading correctly. Absolute animations are currently a WIP.

Madis0 commented 3 years ago

Understandable, but a typical user would not be able to know that, hence the initial suggestion of recommending some packs.

dorianpb commented 3 years ago

Fair enough

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 14 days. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been automatically closed due to it being stale for 14 days. Thank you to everyone who contributed.

Madis0 commented 2 years ago

Are you still considering it?

dorianpb commented 2 years ago

Oh whoops completely forgot about this I don't really have a lot of time to scroll through resource packs to rate them but if you or anyone had suggestions I could make a list. Also, I was waiting until release 0.7.0 before doing this, because that's when I plan to support FreshAnimations

Madis0 commented 2 years ago

I don't really have a lot of time to scroll through resource packs to rate them but if you or anyone had suggestions I could make a list.

But which resource packs are you testing the mod on? That could be a nice start.

dorianpb commented 2 years ago

Right now the only ones are FreshAnimations and the Super Mario pack

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 14 days. Thank you for your contributions.

Madis0 commented 2 years ago

not stale

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 14 days. Thank you for your contributions.

Madis0 commented 2 years ago

still not stale

dorianpb commented 2 years ago

hecking stale bot

twinberrycheesecake commented 2 years ago

banner3

my resource pack fully supports your mod! thanks for your amazing work https://www.curseforge.com/minecraft/texture-packs/wedontbite

dorianpb commented 2 years ago

that's good to know! thanks for the support!

if you don't mind, could you say what you had to change so that hopefully it'll help me figure out what to fix?

twinberrycheesecake commented 2 years ago

the arms for villagers were 1 pixel different in z so I had to adjust it. apart from that, I just slapped it in! however 1.16.5 doesn't seem to work

dorianpb commented 2 years ago

the 1.16.5 version doesn't support villagers, so that's to be expected

Grawl commented 2 years ago

just used Endexyz Mobs models with this mod, thank you for your work!