search

dorimedini / robustness_properties

GLOBIGLOBIGLOBI
0 stars 0 forks source link

Now correctly parse input layers_to_freeze #117

Closed dorimedini closed 5 years ago

dorimedini commented 5 years ago

Previously if layers_to_freeze=[1,2,3] and get_weighted_layers_indices() returns [1,2,3], then the init would fail on index OOB error: for i=3 in layers_to_freeze, get_weighted_layers_indices()[3] doesn't exist.

Signed-off-by: dorimedini dorimedini@gmail.com

galshachaf commented 5 years ago

It's on purpose. Please don't merge.

On Fri, Sep 6, 2019, 19:57 noamloya notifications@github.com wrote:

@noamloya approved this pull request.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/dorimedini/kardashigans/pull/117?email_source=notifications&email_token=ADHINCCLNQ5I6NCDT4XA5TLQIKDWJA5CNFSM4IULBEKKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD6IETY#pullrequestreview-284983887, or mute the thread https://github.com/notifications/unsubscribe-auth/ADHINCGKFNF7X4JMHMARGULQIKDWJANCNFSM4IULBEKA .

galshachaf commented 5 years ago

You authorized the PR with the changes that cause this.

On Fri, Sep 6, 2019, 20:09 Gal Shachaf galshac@gmail.com wrote:

It's on purpose. Please don't merge.

On Fri, Sep 6, 2019, 19:57 noamloya notifications@github.com wrote:

@noamloya approved this pull request.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/dorimedini/kardashigans/pull/117?email_source=notifications&email_token=ADHINCCLNQ5I6NCDT4XA5TLQIKDWJA5CNFSM4IULBEKKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCD6IETY#pullrequestreview-284983887, or mute the thread https://github.com/notifications/unsubscribe-auth/ADHINCGKFNF7X4JMHMARGULQIKDWJANCNFSM4IULBEKA .

galshachaf commented 5 years ago

not a bug (it's a feature!)

dorimedini commented 5 years ago

חחחחחח