search

dorimedini / robustness_properties

GLOBIGLOBIGLOBI
0 stars 0 forks source link

Add VGG trainer #80

Closed galshachaf closed 5 years ago

galshachaf commented 5 years ago

issue #62

galshachaf commented 5 years ago

whoops, that's a debug statement gone wrong

On Sun, 28 Jul 2019 at 15:51, dorimedini notifications@github.com wrote:

@dorimedini requested changes on this pull request.

In experiment.py https://github.com/dorimedini/kardashigans/pull/80#discussion_r308000247 :

@@ -233,19 +233,21 @@ def return_acc(acc: float, clean_acc: float, relative=False): if self._use_prev_results: prev_results = self._resource_manager.get_existing_results(model_name, dirty_results_name) prev_clean = self._resource_manager.get_existing_results(model_name, clean_results_name)

  • Start by checking if there's anything to do.

  • If all requested results exist we should just return them.

  • no_new_layer_sets = set([str(layers) for layers in layer_indices_list]).issubset(set(prev_results.keys()))
  • no_new_epochs = set([str(e) for e in checkpoint_epochs]).issubset(set(list(prev_results.values())[0].keys()))
  • self.logger.debug("Previous results {} all layer sets in {}"
  • "".format("contain" if no_new_layer_sets else "doesn't have",
  • [str(layers) for layers in layer_indices_list]))
  • self.logger.debug("Previous results {} all checkpoints in {}"
  • "".format("contain" if no_new_epochs else "doesn't have",
  • [str(epoch) for epoch in checkpoint_epochs]))
  • if no_new_layer_sets and no_new_epochs:
  • self.logger.debug("Nothing new to compute, returning previous results")
  • return prev_results, prev_clean
  • if prev_results:
  • print("shouldn't get here")

Why shouldn't we get here...? If we successfully loaded results from disk we should be here

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dorimedini/kardashigans/pull/80?email_source=notifications&email_token=ADHINCAY2JP6C7WLQV7ILTTQBWI4PA5CNFSM4IHMMSRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7Y4ZVA#pullrequestreview-267504852, or mute the thread https://github.com/notifications/unsubscribe-auth/ADHINCD6YBZCRRK6LVOUEMDQBWI4PANCNFSM4IHMMSRA .