search

dorimedini / robustness_properties

GLOBIGLOBIGLOBI
0 stars 0 forks source link

Winnery experiment should output l2 diffs #92

Closed dorimedini closed 5 years ago

dorimedini commented 5 years ago

Solves #89

galshachaf commented 5 years ago

why not use get_weight_distances that noam added? @dorimedini

dorimedini commented 5 years ago

why not use get_weight_distances that noam added? @dorimedini

Fixed. @galshachaf it would be better if you used the review API so the fix requests have context and I can mark them as resolved

galshachaf commented 5 years ago

kinda felt this is relevant to the whole PR :)

dorimedini commented 5 years ago

kinda felt this is relevant to the whole PR :)

@galshachaf No problem, I read the comments anyway, just the 'quote reply' option sucks the conversations are out of context.

I, of course, only every have at most one issue in my PRs so it doesn't matter, but if in some unimaginable hypothetical situation there are two issues and we argue about them (which we kinda like) it gets messy