There's a lot of hardcoded data at the moment, since the application was originally developed for internal usage only. To be specific, the categories where hardcoded stuff needs to be removed are:
which should be instead properly inserted into the database, like here a new column in the person table, specifying whether a person is supposed to be filtered.
which... I'm not sure, to be honest. Something tells me the instance admin might want to edit the templates directly, something tells me it should go into Rocket.toml. Open for any hints.
There's a lot of hardcoded data at the moment, since the application was originally developed for internal usage only. To be specific, the categories where hardcoded stuff needs to be removed are:
IP addresses, like the one at
https://github.com/dorodere/komplett-normale-busliste/blob/c431dee2072818843bc95059a4199a65ba39571c/src/authflow.rs#L152
which should go into
Rocket.toml.Person IDs, like
https://github.com/dorodere/komplett-normale-busliste/blob/c431dee2072818843bc95059a4199a65ba39571c/src/sql_interface.rs#L372
which should be instead properly inserted into the database, like here a new column in the
persontable, specifying whether a person is supposed to be filtered.Strings, like
https://github.com/dorodere/komplett-normale-busliste/blob/c431dee2072818843bc95059a4199a65ba39571c/templates/login.html.hbs#L26
which... I'm not sure, to be honest. Something tells me the instance admin might want to edit the templates directly, something tells me it should go into
Rocket.toml. Open for any hints.