search

doron-cohen / antidot

Cleans up your $HOME from those pesky dotfiles
MIT License
299 stars 18 forks source link

Fix incorrect line endings #247

Closed billy4479 closed 10 months ago

billy4479 commented 10 months ago

See #246 for context. It's not very pretty but it works.

Closes #246

doron-cohen commented 10 months ago

Thanks for the fix. I will test it manually and if it works will approve

billy4479 commented 10 months ago

Actually, I probably made a mistake while testing this issue because for some reason I am not able to reproduce this either by building it myself or using the aur packages.

I'm not sure how I got it in the first place, I'll try to provide some instructions on how to reproduce (if I manage to do it), otherwise you are very free to ignore this PR, sorry for the trouble.

billy4479 commented 10 months ago

Turns out that, citing the go spec

Carriage return characters ('\r') inside raw string literals are discarded from the raw string value.

so this fix isn't really fixing anything.

I'll close this PR and do some further investigation and if i manage to reproduce it I'll update the issue.