Closed lucas-mior closed 3 years ago
Thanks for trying to fix this @lucas-mior . I added a test to your branch, which demonstrates the issue and it seems it's not fixed completely (run make test
):
Checks substitution of multiple pistol-extra arguments without
a space between them (issue 56). The output should be:
tests/multi-extra AxB
-------------------
tests/multi-extra %pistol-extra0%xB
Without your change to previewer.go
the test fails even worse:
tests/multi-extra
So this is a good start.
Weird, running make test
in my machine results in
...
-------------------
Checks substitution of multiple pistol-extra arguments without
a space between them (issue 56). The output should be:
tests/multi-extra AxB
-------------------
tests/multi-extra AxB
Weird, running
make test
in my machine results in
Weird indeed, perhaps I forgot to run make
after I tested some changes.. Thanks for the fix! Could you please review the comments I added by reading your code? If you'd like to do / suggest changes please squash the commits.
The comments look fine to me.
adresses #56 I don't think it's an elegant solution, but it should work.