133 share travel

[ani119]

Add share travel ability. After click on share icon, the dialog appears. It include user friends list without users which already have access to the travel.

[magasol]

I would keep edit icon in the end what do you think?

[ani119]

I would keep edit icon in the end what do you think?

Ok, so you want to have order: picture,share,edit? If it is possible I wanna finish minimum 1 pull request today, tomorrow i must return laptop about 7 am :/ But in the nearest future i will buy extra ram or maybe new laptop

[ani119]

new version

[anna-malizjusz]

And generally: Crt+alt+L almost everywhere ;)

[magasol]

but not in xmls ;p

[magasol]

if you could explain the proccess? user clicks on share icon -> the list displayed is with all friends or just the once that doesn;t have access to travel? -> user checks friends, do you send a list of all friends or just the checked once?

[ani119]

1) User click button share 2) User see dialog with list of emails, which belong to his friends, whos do not have access to selected travel 3) User select some of displayed emails 4) User click ok 5) All of selected users get access to travel

[ani119]

@magasol @anna-malizjusz @dorotatomczak Could you write me what exaclty I should improve in my code? - all mistakes in list. I want to implement all of your suggestions and finally move on to the next task. As if you could also agree on corrections, because your conflicting suggestions are really confusing. I want to be more engaged to all project, not only two functionalites

[dorotatomczak]

@ani119 I'm waiting till you fix what needs to be fixed in previous PR. @anna-malizjusz and @magasol have left you comments

[dorotatomczak]

I think you can merge it

[dorotatomczak]

if @magasol doesn't have anything against it