search

dorset-ics / healthcare-data-exchange

A FHIR based integration and interoperability platform to support a regional healthcare network.
https://dorset-ics.github.io/healthcare-data-exchange/
MIT License
6 stars 6 forks source link

Update .env.template with placeholders #13

Closed tectonia closed 3 months ago

tectonia commented 3 months ago

Replaces the following hardcoded vaules in docker/.env.template with placeholders:

gaurarpit commented 3 months ago

i am just thinking, they will always now be in the git commit history. so, anyone can go back and look. I am not blocking this PR and approving it, but, let's chat about this topic. I dont know what the right solution would be. Let's brainstorm.

tectonia commented 3 months ago

i am just thinking, they will always now be in the git commit history. so, anyone can go back and look. I am not blocking this PR and approving it, but, let's chat about this topic. I dont know what the right solution would be. Let's brainstorm.

Client ID and tenant ID are not secrets per se. They are discoverable knowing domain name to anyone on the internet I believe. @liammoat correct me if I'm wrong please.

liammoat commented 3 months ago

i am just thinking, they will always now be in the git commit history. so, anyone can go back and look. I am not blocking this PR and approving it, but, let's chat about this topic. I dont know what the right solution would be. Let's brainstorm.

Client ID and tenant ID are not secrets per se. They are discoverable knowing domain name to anyone on the internet I believe. @liammoat correct me if I'm wrong please.

Yeah - no major concerns from me with these being in the history.

tectonia commented 3 months ago

Unfortunately, the template tests do not succeed with placeholder values. We should investigate further why. I will abandon this PR and raise a work item separately.