rename IDataHubFhirClientWrapper.cs to IFhirClientWrapper.cs as it is…

dorset-ics / healthcare-data-exchange

A FHIR based integration and interoperability platform to support a regional healthcare network.

https://dorset-ics.github.io/healthcare-data-exchange/

MIT License

6 stars 6 forks source link

rename IDataHubFhirClientWrapper.cs to IFhirClientWrapper.cs as it is… #17

Closed shiranr closed 3 months ago

shiranr commented 3 months ago

Renaming the class to inflect what it is actually doing. It is not related to the DataHub and it's goal is to wrap the fhir client so we can mock it in tests

Please add a description of what this PR is changing.

[ X ] Tests
[ X ] Documentation

liammoat commented 3 months ago

@shiranr I'm not sure I agree with this PR. This wrapper is the Fhir client wrapper for the Data Hub? By calling it FhirClientWrapper it causes confusion with the other client wrapper we have PdsFhirClientWrapper.

The name is an important distinction - so we know if we're talking to Pds Fhir, our own Data Hub Fhir.

I propose we leave as-in, with PdsFhirClientWrapper and DataHubFhirClientWrapper

shiranr commented 3 months ago

Closed the PR.