gaurarpit
commented
3 months ago addressing the PR comments from Frances' computer.
Closed gaurarpit closed 3 months ago
gaurarpit
commented
3 months ago addressing the PR comments from Frances' computer.
This pull request includes changes to the
PatientModule.cs,PdsService.cs,DataHubFhirClient.cs, andPdsServiceTests.csfiles, and adds new test sample files. The changes primarily focus on handling invalid patient data, improving error handling, and refactoring test code for better readability.Changes to error handling and patient data processing:
src/Infrastructure/DataHub/Clients/DataHubFhirClient.cs: Upgraded the log level from Debug to Error when a resource is not found in the FHIR service.Changes to test setup and execution:
tests/Unit.Tests/Core/Pds/PdsServiceTests.cs: Added new dependencies and refactored test setup and execution to handle the new logic for invalid patient data. [1] [2] [3] [4] [5] [6] [7] [8]This pull request introduces significant changes to thePdsServiceclass, and its corresponding tests, to improve the handling of patient data. The main changes are the introduction of a new method to delete patients by ID, handling of invalid patients, and refactoring of the test suite to improve readability and maintainability.Changes to the
PdsServiceclass:Changes to the
PdsServiceTestsclass:tests/Integration.Tests/Core/Pds/PdsServiceTests.cs: Refactored the test suite to improve readability and maintainability. Introduced helper methodsCreatePatient,CreateDummyMeshPatientMessageand removed redundant code. [1] [2] [3] [4]Changes to the
PdsServiceTestsclass:tests/Unit.Tests/Core/Pds/PdsServiceTests.cs: Refactored the test suite to improve readability and maintainability. Introduced helper methods and removed redundant code. [1] [2] [3] [4] [5] [6] [7] [8]tests/Unit.Tests/Core/Pds/PdsServiceTests.csIntroduced two new unit tests for delete case and merge case[x] Tests
Stories: #AD27863, #AD30271