dortania / OpenCore-Legacy-Patcher

Experience macOS just like before
https://dortania.github.io/OpenCore-Legacy-Patcher/
Other
13.04k stars 1.24k forks source link

[Bug]: Wrong AGPM Enabler kext generated for my AMD RX 580 GPU #525

Closed MacNB closed 3 years ago

MacNB commented 3 years ago

Machine Model

MacPro5,1

Application Version

Latest Release

Application Variant

TUI (Text User Interface)

What versions of macOS are you seeing the problem on?

macOS 10.15, Catalina

Where does this issue happen?

Other/Non-Applicable

What is the Isssue?

Wrong AGPM Enabler kext generated for my AMD RX 580 GPU. When selecting Build OpenCore from the TUI menu, I see: `- Adding AppleGraphicsPowerManagement Override

The generated EFI boots fine. The generated Injector kext (AGPM-Override.kext) has info.plist with NVIDIA GPU overrides and not AMD. That is, it has: Screenshot 2021-09-30 at 16 55 22

Replacing that AGPM-Override.kext with RadeonBoost.kext solves the problem: Screenshot 2021-09-30 at 17 00 38

Any Additional Information

The MacPro already had OpenCore installed via Martin Lo's package here. It booted fine and I then ran OCLP to generated a new EFI and installed that OVER the existing EFI.

So, the questions are:

  1. Why does OCLP not detect the device path of the dGPU ?
  2. Also, if OCLP found dGPU 1002:67DF then, can that Ven-ID:Dev-ID be used instead to generate the correct AGPM Injector kext ?

Here's a the output of the build process:

`Building Configuration on model: MacPro5,1 Created build folder

Your OpenCore EFI for MacPro5,1 has been built at: /private/var/folders/61/5b228j294l5_p5fpr9fq4nzm0000gn/T/_MEIRiKh7A/Build-Folder/OpenCore-Build

Press [Enter] to go back.`

khronokernel commented 3 years ago

AGPM kext is hardware agnostic, it's simply back porting with correct board ID. Has no relevance to hardware detected other than the model itself

Also, if OCLP found dGPU 1002:67DF then, can that Ven-ID:Dev-ID be used instead to generate the correct AGPM Injector kext ?

You'd need to reverse and write your own AGPM kext then. Far outside the scope of OCLP, for quite little benefit. AGPM mainly benefits mobile devices with constrained temperatures

MacNB commented 3 years ago

Thanks for the quick reply. What is the point of generating and loading the AGPM kext (on a MacPro) that does not have an NVIDIA GPU and so does nothing ? Was the choice of the Nvidia based on "standard" MacPro configuration rather than what's actually installed ? For that matter, is there any point in having that kext other than on mobile devices ?