dortania / bugtracker

Dortania Bugtracker
108 stars 7 forks source link

Battery Patching #8

Open khronokernel opened 4 years ago

khronokernel commented 4 years ago

At the moment, we direct users to Rehabman's guides on battery patching. I would like to move away from it at some point as users get confused trying to adapt Clover properties to their system. Main things I'd like to implement down the line:

Battery patching in general is not a top priority, so would greatly appreciate any outside contributions like PRs. Would likely go in the ACPI Guide as to fit with the rest.

References:

dreamwhite commented 3 years ago

Dear @khronokernel, in those two days I tried (and succeeded) hot-patching an HP laptop battery status using RehabMan's guide. What I've noticed, while reading the guide is that there aren't many images and this can lead the user to confusion. Also, despite the ACPI patching argument is still a hot topic, providing more examples may be better and can avoid lot of confusion.

Regarding this point, would you like that I write (or better, rewrite) RehabMan's battery patching guide both in "hard-patching" (when using directly the DSDT) and "hot-patching" (when using SSDTs+ ACPI Renames)?

Please note that, despite I'll try to do my best, many laptops requires lot of patching, and this process may take up to several hours (FYI it """only""" took me 15 hours to correctly identify the right EC fields and patch them).

Best regards dreamwhite

dreamwhite commented 3 years ago

Update: Dear @dhinakg and @khronokernel I wrote a "small" draft for battery patching using the static patching method (by patching directly DSDT). You can consult the """guide""" here. Please note that I still have to fix many things inside the guide, like avoiding terms repetition and so on. Let me know what you think about it and eventually if you'd like a brief introduction to ACPI patching as per issue #9

dreamwhite commented 2 years ago

Hi there, I think this issue can be closed as ECEnabler by 1Revenger1 does already the same job