search

dorukeker / gyronorm.js

JavaScript project for accessing and normalizing the accelerometer and gyroscope data on mobile devices
MIT License
641 stars 65 forks source link

Fixed promises bug #31

Closed superhighfives closed 7 years ago

superhighfives commented 7 years ago

Hey @dorukeker—got around to testing out some other Promise polyfills and found a great tiny one, https://github.com/taylorhakes/promise-polyfill, which I've implemented and fully tested on demo/index.html.

This pr resolves the issues with the previously closed pr, #29. Apologies!

superhighfives commented 7 years ago

I think having the promise polyfill, at that size, is fine. But totally up to you!

dorukeker commented 7 years ago

Hi @superhighfives I think we can keep it with out the promise polyfill. Most mobile browser are now natively supporting it http://caniuse.com/#feat=promises

And if some one wants to target an older browser she can add the polyfill manually. It is also mentioned in the README.md file.

Thanks for the effort. Cheers!