Feature: Multiple Webhooks

[yoavmatchulsky]

This feature will allow adding multiple webhooks and lets each notification use a different webhook. Issue #43

Slack updated their custom integration and now you can only create a Slack App with Incoming Webhook to a single channel. That means that each channel now needs a specific webhook.

Add a new Webhooks settings page to manage all the webhooks (add, delete and test). Each webhook will have a uniquly generated id, a display title and a url (Channel is no longer needed).

= Webhook Class: = handles getting (#get_webhooks) and updating webhooks (#save_webhooks) and a #random_id helper

= Slack Bot: = The bot instance will now hold all the available webhooks, and will use it when sending a message. The notifications now needs to send additional "webhook_id" arg, or "webhook_url" (used for testing)

• Add #get_webhook_url helper
• If no webhook is found, log an error

= Notification Types: = Keep track of all the webhooks by the notification action in NotificationType base class (as $notif_webhooks), and use it in a new helper #get_notification_webhook_data that returns both the webhook_id and the channel (for older integrations). Refactor all the send_message calls in all notification types to use the new helper and send webhook_id to the bot.

• Add webhook_id select when editing notifications

= AJAX: =

• Add webhook_url to the $args to test different webhooks
• Move "Run Test" button to the webhooks page

= JS: =

• Fix .slack_test_integration buttons
• Add handler for New Webhook button
• Open new notification-box when there are no other webhooks

= Upgrade: = Refactor #sn_update_plugin_db to run multiple upgrades. Refactor the previous upgrade to #sn_update_plugin_db_200 and add new #sn_update_plugin_db_210 helper.

The upgrade for v2.1.0 will take the previous global webhook and transform it into the new webhooks array, and then update all the notifications to use the new webhook.

[elig]

Yessssss thank you Yaov, much needed improvement👌

[DorZuberi]

Hi Yoav, Thanks for your contribution.

I will go over it and do some tests to ensure everything works fine and i will update soon.

[elig]

Hi Dor, any update on this?

[DorZuberi]

Hi @elig, I haven't forgot about that, I'm a bit packed up at work, I hope to address it by the end of the coming week.

Sorry for the delay.

[marmotz]

Hi @DorZuberi, any news ? I can't use your exension without this PR :-/

[herbdogu]

Little +1/me too, we have a complex configuration and could use some separation on channels.

[keinar]

Hi @DorZuberi , We talked a few months ago .. you did not have time. Do you have time for updates now? :)

[DorZuberi]

Hi Guys, I'm working on a new a much improved plugin version.

I've created dev branch, you can keep track there on my progress, I hope to have it ready by the end of June.

[ryanherd]

Great news! Always here for testing assistance if needed. Good luck

[keinar]

Wow thanks!! I was waiting for it🙏

בתאריך יום ו׳, 20 במאי 2022, 8:46, מאת Dor Zuberi @.***

:

Hi Guys, I'm working on a new a much improved plugin version.

I've created dev branch, you can keep track there on my progress, I hope to have it ready by the end of June.

— Reply to this email directly, view it on GitHub https://github.com/dorzki/slack-notifications/pull/45#issuecomment-1132498314, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMAPJ4SKLVLHEWPACPJ7CNTVK4RKHANCNFSM4NGYR2EA . You are receiving this because you commented.Message ID: @.***>

[DorZuberi]

Thanks @ryanherd and @keinar :)