search

dos-group / vessim

A co-simulation testbed for carbon-aware applications and systems 🍃
https://vessim.readthedocs.io
MIT License
49 stars 5 forks source link

Fix small mistakes in sil example #194

Closed Impelon closed 7 months ago

Impelon commented 7 months ago

Seems like there are a few small mistakes in the sil example. Consider doing a sqash-merge of these small commits :)

Impelon commented 7 months ago

The test to see if examples/sil_example.ipynb runs is currently not included in the Build workflow. Probably because it would take 24 * 3600 seconds to run it.

If one applies these fixes and reduces the time given for the simulation, the test works fine though. One could consider replacing the until parameter in examples/sil_example.ipynb during the execution of the workflow with sed or similar... Might be a bit overkill though, especially because using sed will only work as long as the example does not significantly change.

birnbaum commented 7 months ago

thanks a lot!