search

dosemu2 / comcom64

64bit command.com
https://github.com/dosemu2/comcom32/
GNU General Public License v3.0
32 stars 5 forks source link

Dosemu tests failing on FDPP with Comcom #96

Closed andrewbird closed 7 months ago

andrewbird commented 7 months ago

The change introduced in b85da89 seems to be causing dosemu tests to fail. In essence a test does the following.

echo hello > hello.txt

On MS-DOS 6.22, DR-DOS 7.01, and FreeDOS 1.2 this produces

$ sod test-imagedir/dXXXXs/e/hello.txt 
000000 68 65 6c 6c 6f 20 0d 0a                          >hello ..<
000008

But after this change to Comcom, when testing on FDPP the following is found in hello.txt

$ sod test-imagedir/dXXXXs/e/hello.txt 
000000 68 65 6c 6c 6f 20 0a                             >hello .<
000007

So this seems to be the cause of the dosemu tests failing. I looked for the bug report that initiated the change, but perhaps the fix affected more than just the single issue.

stsp commented 7 months ago

OK, I applied a very risky fix to dj64dev. Are you building it locally? If so, would it be possible to see if no new regressions appeared?

stsp commented 7 months ago

At least the affected tests seems to pass.

stsp commented 7 months ago

Seems to pass all tests now.

andrewbird commented 7 months ago

Cool, working here too, thanks!