search

doshidak / showdex

Pokémon Showdown extension that harnesses the power of parabolic calculus to strategically extract your opponents' Elo.
GNU Affero General Public License v3.0
104 stars 18 forks source link

FFA support? #125

Closed Legend-Recalls closed 1 year ago

Legend-Recalls commented 1 year ago

since it was implemented in 1.1.3, i thought there wd be a way to switch opponent in FFA match, but I cant see anything like that, is it not implemented yet or am I missing anything? image

doshidak commented 1 year ago

DAMNNN I may have butchered the part where I hide the user selection dropdown if you're a player in the battle. Looks like it completely hides the dropdown for both sides when it should only be on the bottom side (i.e., your opponents). Oops.

I'll go ahead and get this fixed. I know you've been waiting on FFA for a while, so sorry about that :c

Legend-Recalls commented 1 year ago

is this project still in work?

doshidak commented 1 year ago

Yes! Sorry! We took some time off to take care of some life things, so we haven't been able to work on Showdex for awhile. We're back on the grind now though, so I'll make sure this is fixed with the upcoming release.

doshidak commented 1 year ago

We're rushing to get a release out (v1.1.5) with just bug fixes soon in the coming weeks (especially cause Tera detection is broken again, apparently), which will include a fix for this as well.

I really, really do appreciate your patience with this, I know it's been months. (...Time flies :c)

AhmedA1559 commented 1 year ago

Just a quick input about this while this is up on the table, but I feel that it might be better to allow both sides to switch. Locking it to just the user player on one side might be too limiting, as it prevents users from doing calcs between 2 different other players (which might be useful in FFA format or 2v2 multi format, where some users might find it pivotal to do calcs between 2 other players).

@doshidak @Legend-Recalls your thoughts on this?

doshidak commented 1 year ago

@AhmedA1559 I agree! I'll just do that for v1.1.5 cause it'll save me the trouble figuring out why the player selector dropdowns are disabled when you're a player in the game (much easier to just show the dropdown always).

Thanks for your great suggestion! c:

doshidak commented 1 year ago

Hey guys, just sending an update your way!

Finished (& tested) FFA support; the dropdowns should appear regardless if you're playing or spectating now. This will be bundled with the v1.1.5 release!

AhmedA1559 commented 1 year ago

Will the changes be pushed to GitHub before the release?

Legend-Recalls commented 1 year ago

to take care of some life things, so we haven't been able to

lol I see take care man

Just a quick input about this while this is up on the table, but I feel that it might be better to allow both sides to switch. Locking it to just the user player on one side might be too limiting, as it prevents users from doing calcs between 2 different other players (which might be useful in FFA format or 2v2 multi format, where some users might find it pivotal to do calcs between 2 other players).

definitely agreed

Hey guys, just sending an update your way!

Finished (& tested) FFA support; the dropdowns should appear regardless if you're playing or spectating now. This will be bundled with the v1.1.5 release!

waiting eagerly! 🤞