search

doshidak / showdex

Pokémon Showdown extension that harnesses the power of parabolic calculus to strategically extract your opponents' Elo.
GNU Affero General Public License v3.0
104 stars 18 forks source link

Raging bull not the correct type #129

Closed MoltenGluten closed 1 year ago

MoltenGluten commented 1 year ago

When facing a corvinight with my blaze breed tauros, raging bull was shown to do 1/3 of the damage of close combat

doshidak commented 1 year ago

Hmm, that might be a bug with the underlying calculator. (If it is, there are ways to fix this on our end, luckily.) I'll look into this.

Thanks for the report!

doshidak commented 1 year ago

Found the issue!

Was caused by Showdown internally renaming the different formes of Tauros-Paldea, specifically Tauros-Paldea-Fire becoming Tauros-Paldea-Blaze & Tauros-Paldea-Water becoming Tauros-Paldea-Aqua.

The underlying calculator (@smogon/calc) in v1.1.4 is outdated, still referring to the original forme names when determining whether to boost Raging Bull. The upcoming v1.1.5 release includes the fixes made by the @smogon/calc team, one of which is switching these formes to their updated versions.

(I'll close your issue once the fixes have been merged in the upcoming PR.)

Thanks again for your report! :)

doshidak commented 1 year ago

@MoltenGluten By the way, would love to credit you for your contribution on the README. Do you have a Smogon forums username or Showdown username you'd like to go by? Otherwise, I'll just credit you with your GitHub. (Unless you don't want to be credited, then let me know as well!)

MoltenGluten commented 1 year ago

Thanks for the explanations, I've just got into coding myself after years of telling myself to do it and seeing the process you went through was a nice touch. Keep up the good work, My Smogon Username is LordHelix138 for the contribution Thanks so much