search

doshidak / showdex

Pokémon Showdown extension that harnesses the power of parabolic calculus to strategically extract your opponents' Elo.
GNU Affero General Public License v3.0
97 stars 16 forks source link

FEAT: Damage Dealt/Healed for Pain Split #149

Open jmynes opened 1 year ago

jmynes commented 1 year ago

As a newcomer to competitive, I was not aware that Pain Split could still deal about 20% damage to a fully healed Snorlax with a fully healed Dusclops.

Currently this move always shows N/A: image

Since we're already presupposing an HP EV/IV value for the opponent, and we know our own HP, the average health of both players should be estimatable.

Within the current UI, I'm unsure how to show the user that they'll heal. Perhaps the existing damage estimate could have the Heal % value in green on the left side of the -, and DMG % value on the right in white/red?

A tooltip when hovering over the move could also be useful in explaining this.

jmynes commented 1 year ago

In case this is a problem to be implemented upstream, I also opened an issue here: https://github.com/smogon/damage-calc/issues/572

Even if it's not added to the UI, querying the damage/healed calculation could make this easier.

doshidak commented 9 months ago

looks like someone seems to have opened a PR for this! I'll probably just wait for it to be merged (or if it hasn't been merged after some time, I'll just manually pull the changes).

jmynes commented 8 months ago

Looks like a new PR is tied to it, should be merged eventually :) https://github.com/smogon/damage-calc/pull/585

jmynes commented 1 month ago

Woot! They merged Pain Split in damage-calc! https://github.com/smogon/damage-calc/pull/585