search

doshidak / showdex

Pokémon Showdown extension that harnesses the power of parabolic calculus to strategically extract your opponents' Elo.
GNU Affero General Public License v3.0
106 stars 20 forks source link

BUG: Calcdex inconsistently stays open despite closing matches #183

Open jmynes opened 10 months ago

jmynes commented 10 months ago

image

Often, this seems to happen when I have multiple games open at once, and am switching between match history to compare teams while grinding ladder.

I suspect it may have something to do with refocus when matchmaking switches tabs to a found match, but that's just a hunch. Have had this bug for months, keep forgetting to screenshot it.

Device: Desktop computer OS & Version: Windows 10, fully up to date Browser: Microsoft Edge (chromium) Showdex Version: v1.2.2 Format, if applicable: ADV OU

doshidak commented 10 months ago

ah ya I'm definitely aware of this issue, it happens on my end from time-to-time. just didn't bother to fix it cause a simple refresh does the trick, but hoooly that's a lot of Calcdexes haha!

this typically this occurs with battles that have long expired, so when you close the tab, the battle may not be firing the functions that Showdex hooked into initially to close the corresponding Calcdex. didn't know it was this bad on your end, so I'll definitely take a look.

I actually just replied to your other issue (#184), but now seeing this, kinda makes sense why you have so many Calcdexes open. let me know if that's the case.

thanks!

jmynes commented 10 months ago

I actually do happen to have Clear Memory After Tab Closes enabled: image