doshidak / showdex

Pokémon Showdown extension that harnesses the power of parabolic calculus to strategically extract your opponents' Elo.
GNU Affero General Public License v3.0
97 stars 18 forks source link

Gen 1 incorrectly assumes 100% crit probability on Slash #199

Open mpique opened 5 months ago

mpique commented 5 months ago

Captura

Captura4

Captura2

In Gen 1, the critical hit probability is calculated as T/255. For a High critical-hit ratio move T is: Captura3

Since Parasect's base speed is 30, T = 120. That means it's only a 47,06% chance. Any Pokémon whose speed is equal or lower than 65 won't have a guaranteed crit.

I know, I'm pointing at an extremely small inconsistency that affetcts an extremely low number of Pokémon (15) in an extremely niche meta. But I think it's nice that the calc works properly in these situations anyway.

analogcam commented 1 month ago

this is a bug with the damage calc itself, so there's not much we can do, since they automatically apply the crit damage on their end.