search

doshidak / showdex

Pokémon Showdown extension that harnesses the power of parabolic calculus to strategically extract your opponents' Elo.
GNU Affero General Public License v3.0
100 stars 18 forks source link

Torrent boost not working #20

Closed mpique closed 2 years ago

mpique commented 2 years ago

Torrent/Overgrow/Blaze boosts are not being applied to calcs.

doshidak commented 2 years ago

Ah, HP-based boosts. Might've forgotten about those.

Regardless, thanks for letting me know! I'll keep your issue open until this is fixed.

doshidak commented 2 years ago

Actually, I realized why we didn't initially show those boosts: they only power-up moves of a certain type only. So it'd be kinda misleading to show the boosted values for ATK/SPA when it only boosts your Water-type moves (in the case of Torrent).

(Also fun fact: the calculated stats you see in the Calcdex aren't passed to the internal damage calculator, so they don't affect the damage calculations. Those numbers are purely visual, meant to help you strategize when you look at the SPE, for instance.)

The internal damage calculator does take these into account though, as you can see in the screenshots below.

At 100% HP, Flare Blitz does 101.5 - 119.5%:

showdex-blaziken-pre-blaze

At 32% HP (below the 1/3 HP [33%] threshold), Flare Blitz does 150.7 - 178%:

showdex-blaziken-post-blaze

Hope that makes sense!

I'll be closing this issue since this is working as intended. (But if you have an idea of how to indicate this in the UI more clearly, feel free to open another issue!)