doshidak / showdex

Pokémon Showdown extension that harnesses the power of parabolic calculus to strategically extract your opponents' Elo.
GNU Affero General Public License v3.0
97 stars 18 forks source link

[BUG]: Smeargle's move dropdowns in Calcdex pull from Usage only #201

Open jmynes opened 4 months ago

jmynes commented 4 months ago

The moves dropdowns by default opt to hide any illegal moves, which makes sense for most Pokemon, but not for Smeargle: image

Smeargle's dropdowns should be populated by any move that Sketch is capable of copying: https://bulbapedia.bulbagarden.net/wiki/Sketch_(move)#Generation_II

In all gens, these moves cannot be Sketched:

The article also states:

Hyperspace Fury and Dark Void (starting in Generation VII) are unable to be used in battle.
These moves can only be used by Hoopa Unbound or Darkrai respectively, or by a Pokémon that has transformed into them.

In Gen 2, all moves not listed above are Sketchable, except for:

In Gen 3+, all moves may be sketched, other than the list up top from before

In Gen 9:

Starting with Version 3.0.0, Sketch is once again usable.
Sketch can no longer copy Dark Void or Hyperspace Fury,
nor can it copy the newly introduced moves Revival Blessing,
Tera Starstorm, or the Starmobiles' signature moves.
Despite being both inaccessible and unusable,
Breakneck Blitz is also specified as a move that cannot be copied by Sketch.

Device: Desktop computer OS & Version: Windows 10, fully up to date Browser: Microsoft Edge (chromium) Showdex Version: v1.2.3 Format, if applicable: ADV OU

doshidak commented 1 month ago

wooww great writeup! definitely supporting Sketch is in the pipeline, just kinda low priority atm. will refer to this tho when adding this feature, so thanks again! c:

I suppose if you want, there's a setting called Show Illegal Abilities & Moves under OM & LC Support that you can enable in the meantime:

om-lc-support-show-all-options