doshidak / showdex

Pokémon Showdown extension that harnesses the power of parabolic calculus to strategically extract your opponents' Elo.
GNU Affero General Public License v3.0
97 stars 18 forks source link

Damage calculation does not update after power trick #203

Closed BlackCapCoder closed 1 month ago

BlackCapCoder commented 4 months ago

I reported this back in #143, which was fixed by #144, but it has become a problem again. Unlike last time we can now manually enable/disable power trick, so I can see that calcdex does correctly detect the presence of power trick, and it also correctly calculates my effective stats, however, those stats are not used for the purpose of damage calculation!

replay: https://play.pokemonshowdown.com/battle-gen7doublesou-2119518905

On turn 4, calcdex tells me that I have an 8HKO on Noivern with rock slide, but if I manually switch my att/def around (base stats and EVs) and change my nature, we see that it's really a 1HKO. Sure enough, Noivern goes down before it can setup tailwind- calcdex was lying to me.

doshidak commented 1 month ago

wowza, it's been exactly one year, hoooly. but glad you're still with us!

anyway, ya you're totally right, Power Trick wasn't actually doing the trick :o turns out I forgot to make the swap in a new stat override method I apparently added 2ish months after that PR LOL.

calcdex-power-trick-fix-fr-fr-ong

but I went ahead & got that fixed up for ya. will be available in this upcoming version, dropping soon. thanks for your report!! c: