search

doshidak / showdex

Pokémon Showdown extension that harnesses the power of parabolic calculus to strategically extract your opponents' Elo.
GNU Affero General Public License v3.0
105 stars 20 forks source link

Shadow shield and multiscale show the wrong calculations for multi hit moves #66

Open hkr061 opened 2 years ago

hkr061 commented 2 years ago

Browser: Chrome Showdex version: v1.0.5 When using a multi hit move against shadow shield or multiscale pokemon, the calculations assume the damage reduction applies to all hits, instead of just the first.

doshidak commented 2 years ago

Hey there!

This is a known issue, first discovered with Knock Off, where the calc would report 2HKO (for instance), but would become 2-3HKO once the opposing Pokémon's item is knocked off (as opposed to the expected 1HKO). Similar principle applies for multi-hit moves, as each consecutive hit needs to be recalculated with updated conditions (no item in the case of Knock Off and broken Shadow Shield/Multiscale in your case [broken as in no longer having an effect]).

Currently a low-priority fix as we use the O.G Damage Calculator under-the-hood (just the damage calculation part, not the UI). Would prefer those maintaining the O.G Damage Calculator to directly address this, but I can definitely fix this on Showdex's end if the maintainers don't end up pushing a fix in the near future.

I'll keep your issue open until either it's fixed in the O.G Damage Calculator or I fix this myself.

Thanks!

doshidak commented 2 years ago

Also, totally forgot to ask, but as a little token of appreciation for taking the time to submit this bug report, I'd like to credit you by your Smogon Forums username (if you have one)! Otherwise, I can just link your GitHub.

(...Or if you don't want to be credited, no need to reply.)

hkr061 commented 2 years ago

No worries! My forum username is Henkedew. Cheers!