gen8nationaldex formats crashes Calcdex

[doshidak]

this is caused by mega evo items like Mawilite not existing in the Gen 8 Generation object from @pkmn/dex.

import { Dex } from '@pkmn/dex';
import { Generations } from '@pkmn/data';

const gens = new Generations(Dex);
const dexGen8 = gens.get(8);

dexGen8.items.get('Mawilite');

returns:

undefined

we can either load from a previous gen (e.g., gens.get(6)) if dex.items.get() returns undefined, or use the global Dex object from the Showdown client:

Dex.items.get('Mawilite');

returns:

Item {
  id: 'Mawilite',
  num: 681,
  spritenum: 598,
  name: 'Mawilite',
  desc: 'If held by a Mawile, this item allows it to Mega Evolve in battle.',
  shortDesc: 'If held by a Mawile, this item allows it to Mega Evolve in battle.',
  gen: 6,
  exists: true,
  effectType: 'Item',
  itemUser: [
    'Mawile',
  ],
  fling: null,
  isPokeball: false,
  megaEvolves: 'Mawile',
  megaStone: 'Mawile-Mega',
  naturalGift: null,
  onDrive: '',
  onMemory: '',
  onPlate: '',
  zMove: null,
  zMoveFrom: '',
  zMoveType: '',
  zMoveUser: null,
}

note that the following is the return object of dex.items.get() (from @pkmn/dex):

const dexGen6 = gens.get(6);

dexGen6.items.get('Mawilite');

returns:

Item {
  id: 'mawilite',
  num: 681,
  name: 'Mawilite',
  fullName: 'item: Mawilite',
  desc: 'If held by a Mawile, this item allows it to Mega Evolve in battle.',
  shortDesc: '',
  gen: 6,
  exists: true,
  isNonstandard: null,
  kind: 'Item',
  effectType: 'Item',
  itemUser: [
    'Mawile',
  ],
  duration: undefined,
  fling: {
    basePower: 80,
  },
  megaEvolves: 'Mawile',
  megaStone: 'Mawile-Mega',
}

the objects from Dex.items.get() and dex.items.get() share similar properties, but differ slightly, such as the return object from Dex.items.get() not including the isNonstandard property that the return object from dex.items.get() has.

[doshidak]

Down the rabbit hole we go...

Apparently it wasn't enough fixing the item lookup via dex since there are other things like the species and moves that also aren't available in the gen 8 dex.

Anyways, got gen8nationaldex* formats working for the most part:

Had to add a couple checks to conditionally change the gen to 7 we're in since solely relying on the gen 8 dex crashes the extension. Additionally, slowly working on phasing out using the dex from @pkmn/dex and using the global Dex object that's available in the Showdown client instead.

• Correctly updated the abilities once the speciesForme changed for Mawile in the above screenshot due to hitting the mega-evolution (from 'Mawile' to 'Mawile-Mega'), which changed the ability from 'Intimidate' to 'Huge Power'.
• You'll notice that the IVs and EVs for opponent's Serperior are all orange.
  • This is a new feature to visually indicate that the Pokémon has no spread at all, so you should manually apply it.
  • Curiously, sets for Serperior and Greninja don't exist in gen8.json or even gen8nationaldex.json from the pkmn API.

Will close this via reference on the next PR.