doshyw / CelesteArchipelago

7 stars 6 forks source link

C-Sides check for received Completions instead of Crystal hearts #39

Closed MageoMage closed 4 months ago

MageoMage commented 5 months ago

Been looking a little through the logic files of the apworld and if I am not mistaken in progression.py it states this: (lines 95 onward in the Alpha 0.3.0 release)

        elif side == CelesteSide.C_SIDE:
            return lambda state: state.has_all(
                {
                    BaseData.item_name(CelesteItemType.COMPLETION, level, CelesteSide.A_SIDE),
                    BaseData.item_name(CelesteItemType.COMPLETION, level, CelesteSide.B_SIDE),
                },
                player,
            )

Which if I am reading that correctly means that C-Sides unlock requirements currently are being sent the completion for the A and B side instead of The Crystal Hearts for those as it is stated in en_Celeste.md and how it actually works in the mod iirc.

doshyw commented 4 months ago

Fixed in https://github.com/doshyw/Archipelago/pull/6.