search

dosorio / Peptides

An R package to calculate indices and theoretical physicochemical properties of peptides and protein sequences.
80 stars 21 forks source link

reverting accidental change #11

Closed jspaezp closed 7 years ago

jspaezp commented 7 years ago

reverting accidental change from plot.xvg to plot_xvg ()

dosorio commented 7 years ago

Hi Juan, I'm having problems with plotXVG function in mac. I think the problem is due the use of text as attr, the values of the data frame are now factors. Can you check it?

jspaezp commented 7 years ago

fixed, bug relied in the fact that two variable labels had units in their description (parenthesis), so it tried to assign both of them as the x axis.

Have you considered implementing testhat automatic tests to the project ?

ps: would you mind marking the issue as open and reattaching the branch to the issue?? until we are sure this is fixed, since it would be slightly wasteful to make another pull request for such a slight change

dosorio commented 7 years ago

Thanks! I wrote some RUnit test for some functions when I was in college. However, I think I should review that point again, testhat can be an option. About the issue, I think that this is the develop branch, it is not necessary.