search

dosorio / Peptides

An R package to calculate indices and theoretical physicochemical properties of peptides and protein sequences.
80 stars 21 forks source link

fix bug of failing to read non-white spacing leading lines #23

Closed hongbo-zhu-cn closed 5 years ago

hongbo-zhu-cn commented 5 years ago

the old code fails to read lines without white space in the beginning of data lines, e.g. when the time unit is picosecond:

50000.00000 123.00000 50010.00000 123.00000 50020.00000 123.00000

dosorio commented 5 years ago

Thank you very much!

hongbo-zhu-cn commented 5 years ago

Hi, Daniel,

thank you for your quick response. But unfortunately I have notice that my fix does not work perfectly: it does not remove leading white spaces, as your code did with the pergsub() function. This is cause errors if not every line has leading white spaces. I have a further patch to it (see my fork) and send you another pull request. If you have better fix, feel free to discard my pull request. Sorry for the previous incomplete fix :) best, Hongbo

On Tue, Jul 16, 2019 at 5:06 PM Daniel Osorio notifications@github.com wrote:

Thank you very much!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dosorio/Peptides/pull/23?email_source=notifications&email_token=AAJTYVA6E744UV67FLYB6N3P7XPWBA5CNFSM4ID75N52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2BFBJY#issuecomment-511856807, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJTYVBVPUVPSFYGYOPIXJ3P7XPWBANCNFSM4ID75N5Q .

-- Hongbo

dosorio commented 5 years ago

Hey Hongbo! Thanks for the update! Don't worry, I will double-check all the code before submitting a new version to CRAN.

Regards,

Daniel