search

dosorio / Peptides

An R package to calculate indices and theoretical physicochemical properties of peptides and protein sequences.
80 stars 21 forks source link

Add 'aaSequence' to get all amino acids uppercase single-char names, fix #29 #30

Closed richelbilderbeek closed 4 years ago

richelbilderbeek commented 4 years ago

Hi @dosorio,

As promised, I've added aaSequence, both function and tests.

Sadly, I could not test, as I could not build the package. Because there is no CI on your repo either, you will have to check manually yourself. I am experience adding Travis CI to repos, but I am unsure if you'd be open for that.

Cheers, Richel

codecov-io commented 4 years ago

Codecov Report

Merging #30 into master will increase coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   69.85%   69.92%   +0.06%     
==========================================
  Files          31       32       +1     
  Lines         879      881       +2     
==========================================
+ Hits          614      616       +2     
  Misses        265      265
Impacted Files Coverage Δ
R/aaSequence.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3a471e...dee68b3. Read the comment docs.

richelbilderbeek commented 4 years ago

Blimey, you do have CI! Sorry about that! I am so happy to see that :smile: