Fix incorrect extension on Condition - Githubissues

dot-base / icd-10-api

Rest API to search the 10th revision of the International Statistical Classification of Diseases Database.

GNU General Public License v3.0

18 stars 4 forks source link

Fix incorrect extension on Condition #55

Closed andreakreichgauer closed 1 year ago

andreakreichgauer commented 1 year ago

🔥 Bug Description

Currently, the API returns Condition with incorrect extensions - they are missing a url value. This at least happens on displayCopy.

🔍 Steps to Reproduce the Bug

Was recognized due to a frontend bug in production

🧯 Possible Solution

Quickfix: Set String value for URL.
Check why this extension is added and if it is really needed. I think we added it to not only search on icd codes but also there "chapter"-descriptions

🚧 Important

If extensions are removed from ICD-10-Api, this Issue would also need a migration on exisitng data

velramiir commented 1 year ago

This was probably caused by old data, because the current API version does not return any extensions.

andreakreichgauer commented 1 year ago

This was already fixed with https://github.com/dot-base/icd-10-api/pull/25. The error only came up again due to existing Conditions that need a migration. I opened an issue for this https://github.com/dot-base/fhir-resources/issues/454