dot-i / k8s-operator-node

NodeJS Kubernetes operator framework
Apache License 2.0
155 stars 25 forks source link

Support for filtering watchResource with labels #11

Open kturcios opened 3 years ago

kturcios commented 3 years ago

As the title says, it would be a great feature to be able to filter watchResource by labels. Perhaps just expose a few of the options available for the watch query params? e.g.


export type WatchOptions = {
  labelSelector: { [key: string]: string; };
}

protected async watchResource(
  group: string,
  version: string,
  plural: string,
  onEvent: (event: ResourceEvent) => Promise<void>,
  namespace?: string,
  options: WatchOptions,
): Promise<void>

I would be happy to work on this and open a PR.

Btw, I'm curious if your implementation is inspired by any existing solution like the Operator SDK?

dot-i commented 3 years ago

Sounds like a good suggestion, so feel free to send in a PR for this if you have the time.

Implementation is not really inspired by the Operator SDK, no. So maybe there are a few interesting ideas to "borrow" from there to further improve this package? 😉