Pull request guidelines

[rajbos]

Should we create a PR guideline document describing whats deemed necessary for actually reviewing a pull request?

For instance:

• unit tests on new code (and what framework!?)
• ?

[dot-net-zuid]

That's a good idea, although we don't want to be too strict, especially in the beginning, to gain some traction.

Please go ahead and propose some guidelines.

[Creations2Be]

Just to open up a discussion... Should testing be:

• "unit-testing" (as-in "testing a unit-or-work") or
• "automated testing" (as-in "make sure all/most code-paths have been tested")

Regarding framework I'd propose xUnit because it spans both Core and Full .Net framework and has some neat features for custom extensions.

[bmaluijb]

Ideally, it would be both. But I don’t want to make it too difficult to start contributing. Let’s start out with at least Unit tests.

Also, I like the idea of using xUnit.