search

dotBunny / VSCode

Unity Visual Studio Code Integration
MIT License
673 stars 180 forks source link

Make it work on Insiders distribution #118

Closed nfantone closed 8 years ago

nfantone commented 8 years ago

Packaged version of the plugin won't open project files if using the Insiders version of vscode.

To fix this, the bundle identifier should be changed to:

proc.StartInfo.Arguments = " -n -b \"com.microsoft.VSCodeInsiders\" --args " + args;
reapazor commented 8 years ago

This was resolved in 394fd11504ccba5efee5eb4fbf1c99245be227f3.

My goal is to submit updates to the UAS once a month, i plan on doing a cleanup release end of this month. Most likely the path is going to get a nice little button to navigate to the executable etc.

reapazor commented 8 years ago

i'm going to leave this open as a reminder :)

reapazor commented 8 years ago

1e1a2e01c83a01c356dd6317b1fba2ae9771f30f improved on it

nfantone commented 8 years ago

@reapazor This is still not working for me after upgrading to latest plugin version (2.7) and Unity 5.4f3. Nothing happens when selecting "Assets > Open C# Project in Code" or clicking the "Open" button on the inspector for script files.

However, it does work when changing the value of UseShellExecute to true here.

proc.StartInfo.UseShellExecute = true;

Although, that raises an InvalidOperationException exception which is shown on Unity's console.

InvalidOperationException: UseShellExecute must be false when redirecting I/O.
System.Diagnostics.Process.Start_shell (System.Diagnostics.ProcessStartInfo startInfo, System.Diagnostics.Process process)
System.Diagnostics.Process.Start_common (System.Diagnostics.ProcessStartInfo startInfo, System.Diagnostics.Process process)
System.Diagnostics.Process.Start ()
nfantone commented 8 years ago

I'm creating a new issue, so this doesn't go unnoticed among the closed.