search

dotBunny / VSCode

Unity Visual Studio Code Integration
MIT License
673 stars 180 forks source link

crash with unity2017.2 ?? #156

Closed chiuan closed 7 years ago

chiuan commented 7 years ago

crash with unity2017.2 ??

always ....please help...

thorning commented 7 years ago

I get a lot of crashes with 2017.2 as well. It seems to happen 50% of the time when I press play after making code changes.

A loader window popup with title "VSCode" and text "Checking for updates". I get this every time I edit code and return to unity, and then again when I press play in the editor, but it only crashes when I press play.

I have my platform set to iOS and use .net 4.6

thorning commented 7 years ago

It seems the error happen in the function CheckForUpdate in VSCode.cs:480. Disabling this with a return statement line 1 solved the crashes as a quick fix.

jasontuttle commented 7 years ago

I'm seeing crashes as well on Unity 2017.2 -- It happens every time I quit Unity. Just tried removing VSCode, and the crashes went away. I also tried disabling "CheckForUpdate" per thorning's comment above. No luck, still crashes every time I quit Unity.

chiuan commented 7 years ago

@jasontuttle i have fix this .

just comment the Function "UpdateUnityPreference" > "// FixUnityPreferences();" the last line. it works.

jasontuttle commented 7 years ago

@chiuan is correct: Commenting out the last line of the Function "UpdateUnityPreference" > "// FixUnityPreferences();" fixes the problem.

Thanks @chiuan !!!

reapazor commented 7 years ago

That line was used to fix an issue where preferences werent being read. Might mean the bug in Unity was resolved with that and would stop the crash accordingly.?