Closed wezell closed 1 year ago
Internal QA: Needs work
https://user-images.githubusercontent.com/8741395/192639894-bb03e44c-9847-4e61-ab3c-e0bbb05b8338.mov
B- Content type edition (Icon dropdown)
https://user-images.githubusercontent.com/8741395/192652277-ba46419b-deea-410f-8e95-ce05aab5bda0.mov
https://user-images.githubusercontent.com/8741395/192652869-cc01c7ad-8b2e-4d99-8a37-853f18d2cee9.mov
https://user-images.githubusercontent.com/8741395/192656799-6b956aa0-b4e5-47d6-915b-dd4f3f6ce5ab.mov
Notes for new findings on https://github.com/dotCMS/core/issues/22835#issuecomment-1260078706 1) that is a DOJO dropdown and is out of scope. A new bug was created for that https://github.com/dotCMS/core/issues/23070
2.A ) A style was added to show when the user focus on an option item in the dropdown. In this field a native PrimeNG component is being used, so the behavior is the same as it was designed by the authors (you can compare the behavior here). Note: if the behavior needs to meet others components, then a major refactor needs to be done, it will be out of scope and a new task will be required.
4 ) this won't be fixed on this task, the way that component was built in Rules is too attached and trying to fix it has lots of potentials to break rules. Explanation: every time an option is pick from the dropdown, the whole Rule Action components get re-rendered so you endup with new html components that makes you loose focus and can not continue navigating with the keyboard
Internal QA: Passed
According to the comment left here, I tested cases 2.B and 3 which are working as expected.
Approved QA - Tested on 22.11_4889b92f_SNAPSHOT // Docker // macOS 12.6 FF v106.0.3
Related to #23289
Acceptance Criteria:
Example of Dropdowns in NG app
Login As dialog
Persona dialog
Edit Layout - Add Container
Theme selection
Create template
Note: If you do "Inspect" on your browser and find css class "dijit", then it's a DOJO dropdown (implementation not included on this task)