search

dotCMS / core

Headless/Hybrid Content Management System for Enterprises
http://dotcms.com
Other
860 stars 467 forks source link

Redirect Rule adds request params twice #25178

Open damen-dotcms opened 1 year ago

damen-dotcms commented 1 year ago

Parent Issue

No response

Problem Statement

If you put in

https://dotcms.com?utm_source=newsletter&utm_medium=email&utm_campaign=My+Great+Campaign&utm_id=1234

The URL that resolves has the UTM parameters listed twice.

https://www.dotcms.com/?utm_source=newsletter&utm_medium=email&utm_campaign=My+Great+Campaign&utm_id=1234&utm_source=newsletter&utm_medium=email&utm_campaign=My+Great+Campaign&utm_id=1234

Steps to Reproduce

Click on this.

https://dotcms.com?utm_source=newsletter&utm_medium=email&utm_campaign=My+Great+Campaign&utm_id=1234

Watch how the UTM parameters double.

Acceptance Criteria

UTM codes should be passed through, but not doubled.

dotCMS Version

Happens on our live marketing site.

Proposed Objective

Marketing

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

https://dotcms.zendesk.com/agent/tickets/114417

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

waqasakramdot commented 10 months ago

I am having this issue while working on ticket https://dotcms.zendesk.com/agent/tickets/114417

waqasakramdot commented 1 month ago

@fmontes @erickgonzalez I am still having this issue for https://dotcms.freshdesk.com/a/tickets/27489 and can reproducible on demo 24.08.27 so did this issue come up again?

waqasakramdot commented 1 month ago

This is reproducible on 23.01.22 and above

waqasakramdot commented 3 weeks ago

Another customer asked for this fix here https://dotcms.freshdesk.com/a/tickets/27824

wezell commented 3 weeks ago

I am wondering about the urgency here as duping URI parameters should not have any untoward effects (unless they are being evaled as String[]s ? What is broken here save for the aesthetics of having pretty parameters?

erickgonzalez commented 1 week ago

@waqasakramdot can you provide some steps to reproduce? I tried in the latest main branch and I'm unable to replicate it (see attached video).

https://github.com/user-attachments/assets/18832819-7446-4ab3-bc53-a2e1933f2eb1

erickgonzalez commented 4 days ago

Customer brought STR here https://dotcms.freshdesk.com/a/tickets/27824.

1- Create a folder funds 2- Create a subfolder etf 3- Create index page for both folders 4- Create the following rule Image

5- Hit the url funds/?type=etf 6- Should redirect to ETF page 7- Query params are getting dupe

github-actions[bot] commented 1 day ago

PRs: