dotCMS / core

Headless/Hybrid Content Management System for Enterprises
http://dotcms.com
Other
831 stars 464 forks source link

Update puppeteer to 14.2.0 or above #26396

Open fmontes opened 11 months ago

fmontes commented 11 months ago

User Story

As a dotCMS user, I want to be able to update puppeteer to 14.2.0 or above, so I can use the latest version of the library.

This fixes the arm64 on mac issue requiring separate steps to install and alter .zshrc files. as long as PUPPETEER_EXPERIMENTAL_CHROMIUM_MAC_ARM=true is in the environment when it initially installs it can download a working binary and places it in ~/.cache/puppeteer, after that it just uses that binary fine from then on without homebrew etc.

Acceptance Criteria

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.:

N/A

Assumptions & Initiation Needs

Quality Assurance Notes & Workarounds

N/A

Sub-Tasks & Estimates:

spbolton commented 9 months ago

The question becomes whether we need puppeteer at all. If I remove our explicit declaration in our package.json the main integrated build currently works on mac. Even if another package has a test dependency on it I would think that would only impact when that is actually used and in those cases we would still need to follow the steps for installing chromium, but just be removing the explicit dependency we prevent the need for every m1+ mac from needing to follow manual steps before building dotcms.

fmontes commented 1 month ago

For what I can tell we're only using puppeteer for dotcms-webcomponents e2e tests... but we are not running those, I see some options here:

  1. Upgrade stenciljs (the lib we use to build these web components) and this will upgrade puppeteer
  2. Try to upgrade just puppeteer until a version that is still supported by our current version of stenciljs
  3. Just delete puppeteer all together until we actually needed.