dotCMS / core

Headless/Hybrid Content Management System for Enterprises
http://dotcms.com
Other
865 stars 466 forks source link

Clean mod_date after push remove action #26417

Open bryanboza opened 1 year ago

bryanboza commented 1 year ago

Problem Statement

Currently, after performing a push remove action in dotCMS, the mod_date field is not being cleared. This causes issues when trying to send the dependency again, as the system recognizes that the mod_date has not been updated and does not allow the dependency to be pushed.

Steps to Reproduce

Acceptance Criteria

dotCMS Version

Tested on master // Docker // FF

Proposed Objective

Quality Assurance

Proposed Priority

Priority 2 - Important

github-actions[bot] commented 10 months ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

dsilvam commented 2 months ago

The actual fix here shouldn't involve the mod_date since you're not modifying the asset on the sender, you're just push removing it, which again should not alter the mod_date. The fix here involves registering the operation type when saving the asset in our push history table to then filter out any previous pushes which operation type was push-remove from the decision. The other option is just not insert the asset in the history when it's a push-remove, but requires more thinking than a GD issue. In general this is more work than considered to be a GD issue. Removing the label and putting it in the backlog.