Layout Editor: Content moving is removing the content in EMA server

m27iu4 commented 5 months ago

Parent Issue

No response

Problem Statement

content can be moved from one container to another
drag and drop in the same container makes content to disappear
refreshing the page shows the container back in its place
if I try to drag and put the content between containers, it gets removed (from the DOM also)
the problem happens only in the EMA server applications

Steps to Reproduce

drag and drop content on the same container
drag and drop content between containers
there is a video attached where the problem is reproduced
i tried reproducing it on my local instance, but it is not reproducible

Acceptance Criteria

the content shouldn't be removed when dragging and dropping in the same container or between containers
note that refreshing the page solves the issue

dotCMS Version

23.10.24v1lts

Proposed Objective

Technical User Experience

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

https://dotcms.zendesk.com/agent/tickets/115188 screen-capture-content-removed-from-DOM.webm

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

fmontes commented 5 months ago

Add this settings to the old ema app:

[
  {
    "pattern": ".*",
    "urlEndpoint": "https://demospa.dotcms.com/ema",
    "includeRendered": false
  }
]

And reproduce easily.

Looks like when we drop in the same container, we are not emitting the event to reload.

fmontes commented 5 months ago

If we reorder it works.

fmontes commented 4 months ago

@erickgonzalez can you check this one out in master?

fmontes commented 4 months ago

@erickgonzalez tested

erickgonzalez commented 4 months ago

There are still a couple of issues here: 1- When D&D content to another container is no longer disappearing but is taking a couple of seconds to reload (in the master server, it was immediately when I tried). 2- Moving content to a forbidden container or if we decide not to drop it, thus returning it to its original position, the content disappears from the DOM, necessitating a page reload to perform any operations on the content.

fmontes commented 3 weeks ago

@nollymar there were some changes that @freddyDOTCMS did with this and probably this is already fix, we might need to do some IQA and if everything is good we can close it.

dotCMS / core