UVE: Editor doesn't support chained Vanity URLs that are redirects

dotCMS / core

Headless/Hybrid Content Management System for Enterprises

http://dotcms.com

Other

845 stars 465 forks source link

UVE: Editor doesn't support chained Vanity URLs that are redirects #29165

Closed zJaaal closed 2 weeks ago

zJaaal commented 2 months ago

Parent Issue

TBD

Problem Statement

If we create a Vanity URL that is a redirect (Permanent or Temporary) that points to another Vanity URL (Permanent or Temporary) it will never get to the final page inside of the UVE.

Steps to Reproduce

All vanity URLs should be permanent or temporary redirects.

https://github.com/dotCMS/core/assets/63567962/ad8e88bf-1af5-4bfd-81cd-976966e2fdf5

Acceptance Criteria

We should be able to handle N redirects using the Vanity URL since is a possible behavior.

dotCMS Version

trunk-latest

Proposed Objective

Technical User Experience

Proposed Priority

Priority 2 - Important

Assumptions & Initiation Needs

You understand how the UVE fetch the data for the Editor
You understand how Vanity URL works and it's behavior inside the UVE

Quality Assurance Notes & Workarounds

No workarounds at the moment.

zJaaal commented 1 month ago

We have to test this again, could possibly be fixed in this card https://github.com/dotCMS/core/issues/28947

valentinogiardino commented 1 month ago

Passed Internal QA

Tested on docker image: [dotcms/dotcms:trunk_2e54089]

Video

https://github.com/user-attachments/assets/f9fa4bcb-aabc-4bb7-82cf-52f2f172b77a

bryanboza commented 4 weeks ago

This is working now, however I'm getting a NPE in the log every time that I call the chain of vanities, https://gist.github.com/bryanboza/7d7729859e44f2e745fe39f225ff4a6d

We need to tale look of this error and make sure will not affect any other feature when I'm navigating into the final page.

valentinogiardino commented 3 weeks ago

This is working now, however I'm getting a NPE in the log every time that I call the chain of vanities, https://gist.github.com/bryanboza/7d7729859e44f2e745fe39f225ff4a6d

We need to tale look of this error and make sure will not affect any other feature when I'm navigating into the final page.

The exception is not related to UVE or vanity URLs. The NPE was reproducible with the 20240807 starter, which lacks vanity URLs pointing to the pages where the exception occurs. Specifically, the problem arises in the ShortyServlet when it tries to retrieve the inodePath of an image. It fails because some images in the starter have a null liveInode, while the method assumes the presence of a live version, leading to the failure.

Steps to Reproduce the current NPE

Start a new dotCMS instance using the 20240807 starter.
Open an incognito tab.
Navigate to / or /index.
Inspect the dotCMS logs to observe the null pointer exception.

nollymar commented 2 weeks ago

As the exception is related to data, we are catching the NPE and throwing and logging a dotCMS checked exception

rjvelazco commented 2 weeks ago

Passed Internal QA

Tested on docker image: [dotcms/dotcms:trunk_3ecd733]
Local server

Video

https://github.com/user-attachments/assets/9673e2a9-3da9-46f1-9abe-6982fa229b89

bryanboza commented 2 weeks ago

We need to take look the following case here:

If I open the page thought a chained Vanity URL we are getting this exception in the log https://gist.github.com/bryanboza/c7640029c14d4fca1f9a39973cc6141e . But If I tried opening the page directly we are not getting the error.

nollymar commented 2 weeks ago

@bryanboza please share more details to reproduce this error. Are you using full starter data? what page are you using? did you create a new one?

bryanboza commented 1 week ago

Sorry guys, it seems the error is related to the page I selected for the example, so it's not associated with the vanity chain. We can pass on this one for now, and I'll create a new card for it since it's out of the scope of this card.