dotCMS / core

Headless/Hybrid Content Management System for Enterprises
http://dotcms.com
Other
862 stars 468 forks source link

[Logging] : Log less page details when making an unauthorized GraphQL request for a working page (edit mode) #29651

Closed valentinogiardino closed 1 month ago

valentinogiardino commented 2 months ago

Parent Issue

No response

Problem Statement

We are logging too much information about a page when making a GraphQL request for a working page (edit mode) without authentication. image

Steps to Reproduce

Acceptance Criteria

dotCMS Version

Tested on trunk_52d3299

Proposed Objective

Code Maintenance

Proposed Priority

Priority 4 - Trivial

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

Slack conversation: https://dotcms.slack.com/archives/CQNF9PCFQ/p1723654751826279

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

bryanboza commented 2 months ago

We still needing some work here:

We can remove one of those exceptions and also we need to remove the WARN.

nollymar commented 1 month ago

@bryanboza we will remove the duplicate.

The warning is logged by a third-party library. Therefore, that logging level can be defined in the log4j configuration.

dcolina commented 1 month ago

Internal QA: Passed.

As we can see in the following image, the error message is now showing the minimal information required to report the error.

Request: Image

Log trace: Image

It was tested using the docker image dotcms/dotcms:trunk_042b378

bryanboza commented 1 month ago

Fixed, tested on trunk // Docker // FF