dotCMS / core

Headless/Hybrid Content Management System for Enterprises
http://dotcms.com
Other
865 stars 467 forks source link

Unable to run IT from the IDE due to Bean injection Error #30564

Closed fabrizzio-dotCMS closed 1 week ago

fabrizzio-dotCMS commented 1 week ago

Parent Issue

https://github.com/dotCMS/core/issues/30187

Task

some folks were having issues previously not contemplated when running IT directly from the IDE

there were a couple of issues here's the first exception

Caused by: org.jboss.weld.exceptions.DefinitionException: WELD-000075: Normal scoped managed bean implementation class has a public field:  [EnhancedAnnotatedFieldImpl] @Rule public com.dotcms.IntegrationTestBase.name
    at org.jboss.weld.bean.ManagedBean.checkBeanImplementation(ManagedBean.java:235)
    at org.jboss.weld.bean.AbstractClassBean.internalInitialize(AbstractClassBean.java:74)
    at org.jboss.weld.bean.ManagedBean.internalInitialize(ManagedBean.java:107)
    at org.jboss.weld.bean.RIBean.initialize(RIBean.java:69)
    at org.jboss.weld.bootstrap.ConcurrentBeanDeployer$4.doWork(ConcurrentBeanDeployer.java:96)
    at org.jboss.weld.bootstrap.ConcurrentBeanDeployer$4.doWork(ConcurrentBeanDeployer.java:93)
    at org.jboss.weld.executor.IterativeWorkerTaskFactory$1.call(IterativeWorkerTaskFactory.java:62)
    at org.jboss.weld.executor.IterativeWorkerTaskFactory$1.call(IterativeWorkerTaskFactory.java:55)
    at org.jboss.weld.executor.CommonForkJoinPoolExecutorServices.lambda$wrap$0(CommonForkJoinPoolExecutorServices.java:70)
    at java.base/java.util.concurrent.ForkJoinTask$AdaptedInterruptibleCallable.exec(ForkJoinTask.java:1489)

That was caused by a JUnit @Rule public field that weld doesn't allow

Secondly the new UniqueFieldValidationStrategyResolver it was using Field injection rather than constructor injection which was causing an issue while instantiating the bean This bean is used at the very core of dotCMS therefore it is very likely that it will affect pretty much all tests getting executed directly from the ide

Proposed Objective

Same as Parent Issue

Proposed Priority

Same as Parent Issue

Acceptance Criteria

No response

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

github-actions[bot] commented 1 week ago

PRs: