dotCMS / core

Headless/Hybrid Content Management System for Enterprises
http://dotcms.com
Other
865 stars 467 forks source link

Remove circular dependencies and skip:lint tag from data-access lib #30741

Closed oidacra closed 4 days ago

oidacra commented 4 days ago

Parent Issue

No response

Task

Need to remove circular dependencies in the data-accesslibrary and remove the "skip:lint" tag that's currently bypassing dependency checks.

/Users/oidacra/Work/core/core-web/libs/data-access/src/lib/dot-messages/dot-messages.service.ts
  6:1  error  Circular dependency between "data-access" and "utils" detected: data-access -> utils -> utils-testing -> data-access

Circular file chain:
- libs/data-access/src/lib/dot-messages/dot-messages.service.ts
- libs/utils/src/lib/dot-utils.spec.ts
- libs/utils-testing/src/lib/dot-workflows-actions.mock.ts  @nx/enforce-module-boundaries

/Users/oidacra/Work/core/core-web/libs/data-access/src/lib/dot-page-layout/dot-page-layout.service.spec.ts
  8:1  error  Circular dependency between "data-access" and "utils-testing" detected: data-access -> utils-testing -> data-access

Circular file chain:
- libs/data-access/src/lib/dot-page-layout/dot-page-layout.service.spec.ts
- libs/utils-testing/src/lib/dot-workflows-actions.mock.ts  @nx/enforce-module-boundaries

/Users/oidacra/Work/core/core-web/libs/data-access/src/lib/dot-page-render/dot-page-render.service.spec.ts
  6:1  error  Circular dependency between "data-access" and "utils-testing" detected: data-access -> utils-testing -> data-access

Circular file chain:
- libs/data-access/src/lib/dot-page-render/dot-page-render.service.spec.ts
- libs/utils-testing/src/lib/dot-workflows-actions.mock.ts  @nx/enforce-module-boundaries

/Users/oidacra/Work/core/core-web/libs/data-access/src/lib/dot-page-state/dot-page-state.service.spec.ts
  33:1  error  Circular dependency between "data-access" and "utils-testing" detected: data-access -> utils-testing -> data-access

Circular file chain:
- libs/data-access/src/lib/dot-page-state/dot-page-state.service.spec.ts
- libs/utils-testing/src/lib/dot-workflows-actions.mock.ts  @nx/enforce-module-boundaries

/Users/oidacra/Work/core/core-web/libs/data-access/src/lib/dot-page-state/dot-page-state.service.ts
  33:1  error  Circular dependency between "data-access" and "utils" detected: data-access -> utils -> utils-testing -> data-access

Circular file chain:
- libs/data-access/src/lib/dot-page-state/dot-page-state.service.ts
- libs/utils/src/lib/dot-utils.spec.ts
- libs/utils-testing/src/lib/dot-workflows-actions.mock.ts  @nx/enforce-module-boundaries

/Users/oidacra/Work/core/core-web/libs/data-access/src/lib/dot-page-tools/dot-page-tools.service.spec.ts
  4:1  error  Circular dependency between "data-access" and "utils-testing" detected: data-access -> utils-testing -> data-access

Proposed Objective

Code Maintenance

Proposed Priority

Priority 2 - Important

Acceptance Criteria

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

oidacra commented 4 days ago

Fixed.