search

dotCMS / core

Headless/Hybrid Content Management System for Enterprises
http://dotcms.com
Other
862 stars 468 forks source link

Make #getMostViewed use dotcontent.find #3296

Closed wezell closed 11 years ago

wezell commented 11 years ago

The #getMostViewed macro uses #getContentletByIdentifier macro. We need to make it use the $dotcontent.find method.

jtesser commented 11 years ago

merged into master and master-2.5

QA I haven't tested this yet. I assume @wezell did but it is a change to pulling the content down make sure it still works as it use to

DeanGonzalez commented 11 years ago

Hey Guys,... I tried clicking around the front end and then even tried generating dashboard data... and then tried passing velocity var name in call to getMostViewed macro but we are getting no list after macro call.

https://gist.github.com/DeanGonzalez/5bb9a81f7a70b10c4dda

Are we doing something wrong here or is this guy just not working?

jtesser commented 11 years ago

No probably just need to have the session die. That is when the clickstream data makes it unless you have it turned off. Also u need to be on the front end

bryanboza commented 9 years ago

Fixed... Tested on release 3.2.2