dotCMS / core

Headless/Hybrid Content Management System for Enterprises
http://dotcms.com
Other
853 stars 467 forks source link

User's Permissions not fully cascading from "All Sites" #8853

Closed DeanGonzalez closed 8 years ago

DeanGonzalez commented 8 years ago

Tested on dotcms 3.5 nightly build Linux/Postgres

"1- Login as admin 2- Go to CMS Admin // Users 3- Click on a User's Name 4- Click on Permissions Tab 5- Under ""All Hosts"", give the user Publish access to all objects (Hosts, Folders, Containers, etc.), click the ""Cascade Changes"" checkbox and click the ""Apply Changes"" button. "

Failures: Failed to Cascade Containers, Templates, Template-layouts, and Rules

screenshot of what was cascaded: http://screencast.com/t/cEmgoOM5y

screenshot of permissions not fully inherited on host: http://screencast.com/t/N4O0GmbT

No errors in the log - but seems to have completed https://gist.github.com/DeanGonzalez/61062bfa4db9867fe7801309c643af65

freddyucv commented 8 years ago

PR: https://github.com/dotCMS/core/pull/8980

bryanboza commented 8 years ago

After do some testing over the permissions stuff, we still having some problems here

r2

r3

jtesser commented 8 years ago

@bryanboza if the are only losing the job in H2 this is NOT a problem. There is a slow query timeout in h2 and h2 is not a production DB. @freddyucv @jgambarios lets not work on this if that is he case

dsilvam commented 8 years ago

This is not a trivial fix @jtesser and it is not part of the original issue reported here. I would create a separate issue for that case.

jgambarios commented 8 years ago

Following what Daniel and Jason said:

  1. I was able to reproduce the refresh of the screen issue without Freddy's changes, so it needs to be a different ticket.
  2. About Template-layouts, as Daniel said, it is part of this issue, we just need to make sure how it should work or if it is in use.
  3. The h2 problems are not related to the changes made on this ticket
  4. And about the third issue I can't confirm that it was broken with this latest changes.:

"After you go to the site properties --> Permissions, and reset the permissions stuff over the site, when you come back to the user permissions and try to apply cascade permissions again, we are loosing one by one every category...."


I will clean up this ticket and we will back to work on it.

bryanboza commented 8 years ago

I created a separated issue for the h2 error: https://github.com/dotCMS/core/issues/9014 And another for the auto refresh problem: https://github.com/dotCMS/core/issues/9015

jgambarios commented 8 years ago

@freddyucv please remember to include the Functional Tests along with the new requested changes, we missed those tests in the previous merge.

joseorsini commented 8 years ago

Similar issue was tested in Client running 3.3.1 and locally using Starter Data.

Support Ticket: https://my.dotcms.com/tickets/detail.dot?id=c32027ac-4c8f-410d-a0e7-b17d630e2b9b

  1. Create a Literature Content Type with only Two Fields: Title (Text, required, user searchable, listed and indexed) and Description (WYSIWYG).
  2. Add German and French Languages to System, via Website Browser.
  3. Create a single content for this new Content Type, with Default Language.
  4. Open the newly created content and populate all languages with it. Save and Publish.
  5. At this point, 1 Version for Each langauge should be created for the same content.
  6. Go to Sites -> demo.dotcms.com site and add "Nick Reviewer" User to Permissions List. Check all Publish boxes and Cascade all permissions.
  7. Login as Nick Reviewer. Go to Content Search Content.
  8. No Literature Contents are listed.
  9. Go back to Backend with Admin user and Import these Literature Contents https://gist.github.com/joseorsini/c02da5420d252ea9224061e737b33d57 as a Multilingual CSV File.
  10. Go back to backend with Nick Reviewer user. All contents imported from the CSV are listed. Original one created on previous steps is still missing.

Please test.