Unable to get IPAddress when X-Forwarded-For header comes with multiple values

dotCMS / core

Headless/Hybrid Content Management System for Enterprises

http://dotcms.com

Other

865 stars 467 forks source link

Unable to get IPAddress when X-Forwarded-For header comes with multiple values #9002

Closed dsilvam closed 5 years ago

dsilvam commented 8 years ago

Under some circumstances the X-Forwarded-For header can include multiple values, in which case, an exception is happening and it is not possible to get the IP.

We need to:

Properly handle multi-value scenario by getting the first one from the list.
Validate the ip before calling InetAddress.getByName(ip);. (we could use https://commons.apache.org/proper/commons-validator/javadocs/api-1.5.1/org/apache/commons/validator/routines/InetAddressValidator.html)

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had activity within the past 90 days. It will be closed in 30 days no further activity occurs. Thank you.